SpotBugs Bug Detector Report

The following document contains the results of SpotBugs

SpotBugs Version is 4.3.0

Threshold is medium

Effort is default

Summary

Classes Bugs Errors Missing Classes
23 17 0 0

Files

Class Bugs
org.eclipse.jgit.lfs.server.LfsProtocolServlet$LfsRequest 1
org.eclipse.jgit.lfs.server.TransferHandler$Download 2
org.eclipse.jgit.lfs.server.TransferHandler$Upload 3
org.eclipse.jgit.lfs.server.fs.FileLfsRepository 1
org.eclipse.jgit.lfs.server.fs.FileLfsServlet 2
org.eclipse.jgit.lfs.server.fs.ObjectDownloadListener 2
org.eclipse.jgit.lfs.server.fs.ObjectUploadListener 2
org.eclipse.jgit.lfs.server.internal.LfsGson$Error 1
org.eclipse.jgit.lfs.server.s3.SignerV4 3

org.eclipse.jgit.lfs.server.LfsProtocolServlet$LfsRequest

Bug Category Details Line Priority
org.eclipse.jgit.lfs.server.LfsProtocolServlet$LfsRequest.getObjects() may expose internal representation by returning LfsProtocolServlet$LfsRequest.objects MALICIOUS_CODE EI_EXPOSE_REP 139 Medium

org.eclipse.jgit.lfs.server.TransferHandler$Download

Bug Category Details Line Priority

org.eclipse.jgit.lfs.server.TransferHandler$Upload

Bug Category Details Line Priority

org.eclipse.jgit.lfs.server.fs.FileLfsRepository

Bug Category Details Line Priority

org.eclipse.jgit.lfs.server.fs.FileLfsServlet

Bug Category Details Line Priority
new org.eclipse.jgit.lfs.server.fs.FileLfsServlet(FileLfsRepository, long) may expose internal representation by storing an externally mutable object into FileLfsServlet.repository MALICIOUS_CODE EI_EXPOSE_REP2 57 Medium
Class org.eclipse.jgit.lfs.server.fs.FileLfsServlet defines non-transient non-serializable instance field repository BAD_PRACTICE SE_BAD_FIELD Not available Medium

org.eclipse.jgit.lfs.server.fs.ObjectDownloadListener

Bug Category Details Line Priority
new org.eclipse.jgit.lfs.server.fs.ObjectDownloadListener(FileLfsRepository, AsyncContext, HttpServletResponse, AnyLongObjectId) may expose internal representation by storing an externally mutable object into ObjectDownloadListener.context MALICIOUS_CODE EI_EXPOSE_REP2 68 Medium
new org.eclipse.jgit.lfs.server.fs.ObjectDownloadListener(FileLfsRepository, AsyncContext, HttpServletResponse, AnyLongObjectId) may expose internal representation by storing an externally mutable object into ObjectDownloadListener.response MALICIOUS_CODE EI_EXPOSE_REP2 69 Medium

org.eclipse.jgit.lfs.server.fs.ObjectUploadListener

Bug Category Details Line Priority
new org.eclipse.jgit.lfs.server.fs.ObjectUploadListener(FileLfsRepository, AsyncContext, HttpServletRequest, HttpServletResponse, AnyLongObjectId) may expose internal representation by storing an externally mutable object into ObjectUploadListener.context MALICIOUS_CODE EI_EXPOSE_REP2 101 Medium
new org.eclipse.jgit.lfs.server.fs.ObjectUploadListener(FileLfsRepository, AsyncContext, HttpServletRequest, HttpServletResponse, AnyLongObjectId) may expose internal representation by storing an externally mutable object into ObjectUploadListener.response MALICIOUS_CODE EI_EXPOSE_REP2 102 Medium

org.eclipse.jgit.lfs.server.internal.LfsGson$Error

Bug Category Details Line Priority
Unread field: org.eclipse.jgit.lfs.server.internal.LfsGson$Error.message PERFORMANCE URF_UNREAD_FIELD 37 Medium

org.eclipse.jgit.lfs.server.s3.SignerV4

Bug Category Details Line Priority
Format string should use %n rather than \n in org.eclipse.jgit.lfs.server.s3.SignerV4.canonicalRequest(URL, String, String, String, String, String) BAD_PRACTICE VA_FORMAT_STRING_USES_NEWLINE 304 Medium
Format string should use %n rather than \n in org.eclipse.jgit.lfs.server.s3.SignerV4.stringToSign(String, String, String, String, String) BAD_PRACTICE VA_FORMAT_STRING_USES_NEWLINE 347 Medium
org.eclipse.jgit.lfs.server.s3.SignerV4.formatAuthorizationQuery(Map) makes inefficient use of keySet iterator instead of entrySet iterator PERFORMANCE WMI_WRONG_MAP_ITERATOR 128 Medium