PMD Results

The following document contains the results of PMD 6.38.0.

Violations By Priority

Priority 3

org/eclipse/jgit/lfs/LfsBlobFilter.java

Rule Violation Line
EmptyWhileStmt Avoid empty while statements 87–89

org/eclipse/jgit/lfs/LfsPointer.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 120–122
EmptyCatchBlock Avoid empty catch blocks 253–255

org/eclipse/jgit/lfs/LfsPrePushHook.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 10–258
EmptyWhileStmt Avoid empty while statements 119–121

org/eclipse/jgit/lfs/Protocol.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'gson': the method is declared in an interface type 137–142

org/eclipse/jgit/lfs/lib/AbbreviatedLongObjectId.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'isId': the method is already in a final class 48–59
UnnecessaryModifier Unnecessary modifier 'final' on method 'fromString': the method is already in a final class 73–81
UnnecessaryModifier Unnecessary modifier 'final' on method 'fromLongObjectId': the method is already in a final class 94–99
UnnecessaryModifier Unnecessary modifier 'final' on method 'fromString': the method is already in a final class 108–114
UnnecessaryModifier Unnecessary modifier 'final' on method 'fromHexString': private methods cannot be overridden 116–130
UnnecessaryModifier Unnecessary modifier 'final' on method 'hexUInt64': private methods cannot be overridden 132–144
UnnecessaryModifier Unnecessary modifier 'final' on method 'prefixCompare': the method is already in a final class 222–238
UnnecessaryModifier Unnecessary modifier 'final' on method 'prefixCompare': the method is already in a final class 254–270
UnnecessaryModifier Unnecessary modifier 'final' on method 'prefixCompare': the method is already in a final class 286–302
UnnecessaryModifier Unnecessary modifier 'final' on method 'getFirstByte': the method is already in a final class 309–311
UnnecessaryModifier Unnecessary modifier 'final' on method 'name': the method is already in a final class 339–356

org/eclipse/jgit/lfs/lib/AnyLongObjectId.java

Rule Violation Line
SimplifiedTernary Ternary operators that can be simplified with || or && 267

org/eclipse/jgit/lfs/lib/LongObjectId.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'fromHexString': private methods cannot be overridden 219–232

Files

org/eclipse/jgit/lfs/LfsBlobFilter.java

Rule Violation Priority Line
EmptyWhileStmt Avoid empty while statements 3 87–89

org/eclipse/jgit/lfs/LfsPointer.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 120–122
EmptyCatchBlock Avoid empty catch blocks 3 253–255

org/eclipse/jgit/lfs/LfsPrePushHook.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 10–258
EmptyWhileStmt Avoid empty while statements 3 119–121

org/eclipse/jgit/lfs/Protocol.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'gson': the method is declared in an interface type 3 137–142

org/eclipse/jgit/lfs/lib/AbbreviatedLongObjectId.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'isId': the method is already in a final class 3 48–59
UnnecessaryModifier Unnecessary modifier 'final' on method 'fromString': the method is already in a final class 3 73–81
UnnecessaryModifier Unnecessary modifier 'final' on method 'fromLongObjectId': the method is already in a final class 3 94–99
UnnecessaryModifier Unnecessary modifier 'final' on method 'fromString': the method is already in a final class 3 108–114
UnnecessaryModifier Unnecessary modifier 'final' on method 'fromHexString': private methods cannot be overridden 3 116–130
UnnecessaryModifier Unnecessary modifier 'final' on method 'hexUInt64': private methods cannot be overridden 3 132–144
UnnecessaryModifier Unnecessary modifier 'final' on method 'prefixCompare': the method is already in a final class 3 222–238
UnnecessaryModifier Unnecessary modifier 'final' on method 'prefixCompare': the method is already in a final class 3 254–270
UnnecessaryModifier Unnecessary modifier 'final' on method 'prefixCompare': the method is already in a final class 3 286–302
UnnecessaryModifier Unnecessary modifier 'final' on method 'getFirstByte': the method is already in a final class 3 309–311
UnnecessaryModifier Unnecessary modifier 'final' on method 'name': the method is already in a final class 3 339–356

org/eclipse/jgit/lfs/lib/AnyLongObjectId.java

Rule Violation Priority Line
SimplifiedTernary Ternary operators that can be simplified with || or && 3 267

org/eclipse/jgit/lfs/lib/LongObjectId.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'fromHexString': private methods cannot be overridden 3 219–232

Processing Errors

Filename Problem
org/eclipse/jgit/lfs/internal/LfsConnectionFactory.java PMDException: Error while processing /home/jenkins/agent/workspace/stable/jgit-publish-site/repo/org.eclipse.jgit.lfs/src/org/eclipse/jgit/lfs/internal/LfsConnectionFactory.java 
net.sourceforge.pmd.PMDException: Error while processing /home/jenkins/agent/workspace/stable/jgit-publish-site/repo/org.eclipse.jgit.lfs/src/org/eclipse/jgit/lfs/internal/LfsConnectionFactory.java
	at net.sourceforge.pmd.SourceCodeProcessor.processSourceCodeWithoutCache(SourceCodeProcessor.java:128)
	at net.sourceforge.pmd.SourceCodeProcessor.processSourceCode(SourceCodeProcessor.java:100)
	at net.sourceforge.pmd.SourceCodeProcessor.processSourceCode(SourceCodeProcessor.java:62)
	at net.sourceforge.pmd.processor.PmdRunnable.call(PmdRunnable.java:85)
	at net.sourceforge.pmd.processor.PmdRunnable.call(PmdRunnable.java:29)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
	at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
	at java.base/java.lang.Thread.run(Thread.java:829)
Caused by: java.lang.ArrayIndexOutOfBoundsException: Index 24248 out of bounds for length 10507
	at org.objectweb.asm.ClassReader.(Unknown Source)
	at org.objectweb.asm.ClassReader.(Unknown Source)
	at org.objectweb.asm.ClassReader.(Unknown Source)
	at net.sourceforge.pmd.lang.java.typeresolution.PMDASMClassLoader.getImportedClasses(PMDASMClassLoader.java:118)
	at net.sourceforge.pmd.lang.java.typeresolution.ClassTypeResolver.populateClassName(ClassTypeResolver.java:1617)
	at net.sourceforge.pmd.lang.java.typeresolution.ClassTypeResolver.visit(ClassTypeResolver.java:214)
	at net.sourceforge.pmd.lang.java.ast.ASTCompilationUnit.jjtAccept(ASTCompilationUnit.java:44)
	at net.sourceforge.pmd.lang.java.typeresolution.TypeResolutionFacade.initializeWith(TypeResolutionFacade.java:21)
	at net.sourceforge.pmd.lang.java.AbstractJavaHandler$5.start(AbstractJavaHandler.java:121)
	at net.sourceforge.pmd.SourceCodeProcessor.usesTypeResolution(SourceCodeProcessor.java:178)
	at net.sourceforge.pmd.SourceCodeProcessor.processSource(SourceCodeProcessor.java:205)
	at net.sourceforge.pmd.SourceCodeProcessor.processSourceCodeWithoutCache(SourceCodeProcessor.java:118)
	... 10 more